[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v11 04/14] backup: Extract dirty bitmap handling as
From: |
John Snow |
Subject: |
[Qemu-block] [PATCH v11 04/14] backup: Extract dirty bitmap handling as a separate function |
Date: |
Thu, 5 Nov 2015 18:13:10 -0500 |
From: Fam Zheng <address@hidden>
This will be reused by the coming new transactional completion code.
Signed-off-by: Fam Zheng <address@hidden>
Reviewed-by: John Snow <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
Signed-off-by: John Snow <address@hidden>
---
block/backup.c | 27 +++++++++++++++++----------
1 file changed, 17 insertions(+), 10 deletions(-)
diff --git a/block/backup.c b/block/backup.c
index ec01db8..f7fcb99 100644
--- a/block/backup.c
+++ b/block/backup.c
@@ -221,6 +221,22 @@ static void backup_iostatus_reset(BlockJob *job)
}
}
+static void backup_cleanup_sync_bitmap(BackupBlockJob *job, int ret)
+{
+ BdrvDirtyBitmap *bm;
+ BlockDriverState *bs = job->common.bs;
+
+ if (ret < 0 || block_job_is_cancelled(&job->common)) {
+ /* Merge the successor back into the parent, delete nothing. */
+ bm = bdrv_reclaim_dirty_bitmap(bs, job->sync_bitmap, NULL);
+ assert(bm);
+ } else {
+ /* Everything is fine, delete this bitmap and install the backup. */
+ bm = bdrv_dirty_bitmap_abdicate(bs, job->sync_bitmap, NULL);
+ assert(bm);
+ }
+}
+
static const BlockJobDriver backup_job_driver = {
.instance_size = sizeof(BackupBlockJob),
.job_type = BLOCK_JOB_TYPE_BACKUP,
@@ -443,16 +459,7 @@ static void coroutine_fn backup_run(void *opaque)
qemu_co_rwlock_unlock(&job->flush_rwlock);
if (job->sync_bitmap) {
- BdrvDirtyBitmap *bm;
- if (ret < 0 || block_job_is_cancelled(&job->common)) {
- /* Merge the successor back into the parent, delete nothing. */
- bm = bdrv_reclaim_dirty_bitmap(bs, job->sync_bitmap, NULL);
- assert(bm);
- } else {
- /* Everything is fine, delete this bitmap and install the backup.
*/
- bm = bdrv_dirty_bitmap_abdicate(bs, job->sync_bitmap, NULL);
- assert(bm);
- }
+ backup_cleanup_sync_bitmap(job, ret);
}
hbitmap_free(job->bitmap);
--
2.4.3
- [Qemu-block] [PATCH v11 00/14] block: incremental backup transactions using BlockJobTxn, John Snow, 2015/11/05
- [Qemu-block] [PATCH v11 04/14] backup: Extract dirty bitmap handling as a separate function,
John Snow <=
- [Qemu-block] [PATCH v11 03/14] block: rename BlkTransactionState and BdrvActionOps, John Snow, 2015/11/05
- [Qemu-block] [PATCH v11 02/14] iotests: add transactional incremental backup test, John Snow, 2015/11/05
- [Qemu-block] [PATCH v11 01/14] qapi: Add transaction support to block-dirty-bitmap operations, John Snow, 2015/11/05
- [Qemu-block] [PATCH v11 06/14] blockjob: Add .commit and .abort block job actions, John Snow, 2015/11/05
- [Qemu-block] [PATCH v11 05/14] blockjob: Introduce reference count and fix reference to job->bs, John Snow, 2015/11/05
- [Qemu-block] [PATCH v11 09/14] block: Add block job transactions, John Snow, 2015/11/05
- [Qemu-block] [PATCH v11 11/14] block: Add BlockJobTxn support to backup_run, John Snow, 2015/11/05
- [Qemu-block] [PATCH v11 12/14] block: add transactional properties, John Snow, 2015/11/05
- [Qemu-block] [PATCH v11 07/14] blockjob: Add "completed" and "ret" in BlockJob, John Snow, 2015/11/05
- [Qemu-block] [PATCH v11 08/14] blockjob: Simplify block_job_finish_sync, John Snow, 2015/11/05