[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v7 02/24] blockjob: Call bdrv_unref() on creation er
From: |
Max Reitz |
Subject: |
[Qemu-block] [PATCH v7 02/24] blockjob: Call bdrv_unref() on creation error |
Date: |
Mon, 9 Nov 2015 23:39:11 +0100 |
If block_job_create() fails, it should release its reference to the
job's BDS. Normally, this is done in the callback provided by the
caller, but that callback will not be invoked if the block job failed to
be created.
Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
---
blockjob.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/blockjob.c b/blockjob.c
index c02fe59..0886a4a 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -70,6 +70,7 @@ void *block_job_create(const BlockJobDriver *driver,
BlockDriverState *bs,
if (local_err) {
block_job_release(bs);
error_propagate(errp, local_err);
+ bdrv_unref(bs);
return NULL;
}
}
--
2.6.2
- [Qemu-block] [PATCH v7 for-2.6 00/24] block: Rework bdrv_close_all(), Max Reitz, 2015/11/09
- [Qemu-block] [PATCH v7 01/24] blockdev: Add missing bdrv_unref() in drive-backup, Max Reitz, 2015/11/09
- [Qemu-block] [PATCH v7 02/24] blockjob: Call bdrv_unref() on creation error,
Max Reitz <=
- [Qemu-block] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close(), Max Reitz, 2015/11/09
- Re: [Qemu-block] [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close(), John Snow, 2015/11/11
- Re: [Qemu-block] [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close(), Fam Zheng, 2015/11/12
- Re: [Qemu-block] [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close(), John Snow, 2015/11/13
- Re: [Qemu-block] [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close(), Fam Zheng, 2015/11/16
- Re: [Qemu-block] [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close(), John Snow, 2015/11/16
- Re: [Qemu-block] [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close(), Fam Zheng, 2015/11/16
- [Qemu-block] Closing Bitmaps (Was: Re: [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close()), John Snow, 2015/11/17