[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v7 05/24] iotests: Change coding st
From: |
Fam Zheng |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v7 05/24] iotests: Change coding style of _filter_nbd in 083 |
Date: |
Thu, 12 Nov 2015 14:25:43 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, 11/09 23:39, Max Reitz wrote:
> In order to be able to move _filter_nbd to common.filter in the next
> patch, its coding style needs to be adapted to that of common.filter.
> That means, we have to convert tabs to four spaces, adjust the alignment
> of the last line (done with spaces already, assuming one tab equals
> eight spaces), fix the line length of the comment, and add a line break
> before the opening brace.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> tests/qemu-iotests/083 | 19 ++++++++++---------
> 1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/tests/qemu-iotests/083 b/tests/qemu-iotests/083
> index 664f0cf..c00a66b 100755
> --- a/tests/qemu-iotests/083
> +++ b/tests/qemu-iotests/083
> @@ -49,15 +49,16 @@ wait_for_tcp_port() {
> done
> }
>
> -_filter_nbd() {
> - # nbd.c error messages contain function names and line numbers that are
> prone
> - # to change. Message ordering depends on timing between send and
> receive
> - # callbacks sometimes, making them unreliable.
> - #
> - # Filter out the TCP port number since this changes between runs.
> - sed -e 's#^.*nbd\.c:.*##g' \
> - -e 's#nbd:127\.0\.0\.1:[^:]*:#nbd:127\.0\.0\.1:PORT:#g' \
> - -e 's#\(exportname=foo\|PORT\): Failed to .*$#\1#'
> +_filter_nbd()
> +{
> + # nbd.c error messages contain function names and line numbers that are
> + # prone to change. Message ordering depends on timing between send and
> + # receive callbacks sometimes, making them unreliable.
> + #
> + # Filter out the TCP port number since this changes between runs.
> + sed -e 's#^.*nbd\.c:.*##g' \
> + -e 's#nbd:127\.0\.0\.1:[^:]*:#nbd:127\.0\.0\.1:PORT:#g' \
> + -e 's#\(exportname=foo\|PORT\): Failed to .*$#\1#'
> }
>
> check_disconnect() {
> --
> 2.6.2
>
>
Reviewed-by: Fam Zheng <address@hidden>
- Re: [Qemu-block] [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close(), (continued)
- Re: [Qemu-block] [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close(), John Snow, 2015/11/16
- Re: [Qemu-block] [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close(), Fam Zheng, 2015/11/16
- [Qemu-block] Closing Bitmaps (Was: Re: [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close()), John Snow, 2015/11/17
- Re: [Qemu-block] Closing Bitmaps (Was: Re: [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close()), Fam Zheng, 2015/11/17
- Re: [Qemu-block] [Qemu-devel] Closing Bitmaps (Was: Re: [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close()), John Snow, 2015/11/18
- Re: [Qemu-block] Closing Bitmaps (Was: Re: [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close()), Kevin Wolf, 2015/11/18
- Re: [Qemu-block] Closing Bitmaps (Was: Re: [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close()), John Snow, 2015/11/18
[Qemu-block] [PATCH v7 04/24] iotests: Rename filter_nbd to _filter_nbd in 083, Max Reitz, 2015/11/09
[Qemu-block] [PATCH v7 05/24] iotests: Change coding style of _filter_nbd in 083, Max Reitz, 2015/11/09
- Re: [Qemu-block] [Qemu-devel] [PATCH v7 05/24] iotests: Change coding style of _filter_nbd in 083,
Fam Zheng <=
[Qemu-block] [PATCH v7 06/24] iotests: Move _filter_nbd into common.filter, Max Reitz, 2015/11/09
[Qemu-block] [PATCH v7 07/24] iotests: Make _filter_nbd drop log lines, Max Reitz, 2015/11/09
[Qemu-block] [PATCH v7 08/24] iotests: Make _filter_nbd support more URL types, Max Reitz, 2015/11/09
[Qemu-block] [PATCH v7 09/24] iotests: Make redirecting qemu's stderr optional, Max Reitz, 2015/11/09
[Qemu-block] [PATCH v7 10/24] iotests: Add test for eject under NBD server, Max Reitz, 2015/11/09