[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH for-2.5 v2 0/4] block: replace IOV_MAX with Bloc
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-block] [PATCH for-2.5 v2 0/4] block: replace IOV_MAX with BlockLimits.max_iov |
Date: |
Mon, 23 Nov 2015 18:08:16 +0800 |
User-agent: |
Mutt/1.5.23 (2015-06-09) |
On Thu, Jul 09, 2015 at 10:56:43AM +0100, Stefan Hajnoczi wrote:
> v2:
> * Default to IOV_MAX instead of INT_MAX [Peter Lieven]
>
> This series depends on "[PATCH] block/mirror: limit qiov to IOV_MAX elements".
>
> IOV_MAX has been hardcoded in several places since preadv()/pwritev()/etc
> refuse to take more iovecs per call. That's actually an implementation detail
> of raw-posix and we shouldn't spread that across the codebase.
>
> This series adds BlockLimits.max_iov (similar to BlockLimits.max_transfer_len
> and other fields). Current IOV_MAX users are converted to blk_get_max_iov().
>
> By the way, the IOV_MAX vs BlockLimits.max_iov naming is slightly confusing
> but
> follows the BlockLimits field naming convention. Once IOV_MAX is banished no
> one will be bothered by the reverse naming anymore.
>
> Suggested-by: Kevin Wolf <address@hidden>
>
> Stefan Hajnoczi (4):
> block: add BlockLimits.max_iov field
> block-backend: add blk_get_max_iov()
> block: replace IOV_MAX with BlockLimits.max_iov
> block/mirror: replace IOV_MAX with blk_get_max_iov()
>
> block/block-backend.c | 5 +++++
> block/io.c | 8 +++++++-
> block/mirror.c | 6 ++++--
> hw/block/virtio-blk.c | 2 +-
> include/block/block_int.h | 3 +++
> include/sysemu/block-backend.h | 1 +
> 6 files changed, 21 insertions(+), 4 deletions(-)
>
> --
> 2.4.3
>
Thanks, applied to my block-next tree:
https://github.com/stefanha/qemu/commits/block-next
Stefan
signature.asc
Description: PGP signature