[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 03/21] mirror: Error out when a BDS would get
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-block] [PATCH v2 03/21] mirror: Error out when a BDS would get two BBs |
Date: |
Mon, 30 Nov 2015 15:51:18 +0100 |
User-agent: |
Notmuch/0.13.2 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) |
On Mon 23 Nov 2015 04:59:42 PM CET, Kevin Wolf wrote:
> @@ -370,11 +371,22 @@ static void mirror_exit(BlockJob *job, void *opaque)
> if (s->to_replace) {
> to_replace = s->to_replace;
> }
> +
> + /* This was checked in mirror_start_job(), but meanwhile one of the
> + * nodes could have been newly attached to a BlockBackend. */
> + if (to_replace->blk && s->target->blk) {
> + error_report("block job: Can't create node with two
> BlockBackends");
> + data->ret = -EINVAL;
> + goto out;
> + }
Does it make sense to even allow attaching a BDS to a Block Backend
during this block job? Is there any use case for that?
Berto
- Re: [Qemu-block] [PATCH v2 02/21] block: Fix reopen with semantically overlapping options, (continued)
- [Qemu-block] [PATCH v2 03/21] mirror: Error out when a BDS would get two BBs, Kevin Wolf, 2015/11/23
- [Qemu-block] [PATCH v2 01/21] qcow2: Add .bdrv_join_options callback, Kevin Wolf, 2015/11/23
- [Qemu-block] [PATCH v2 07/21] block: Pass driver-specific options to .bdrv_refresh_filename(), Kevin Wolf, 2015/11/23
- [Qemu-block] [PATCH v2 09/21] block: Allow specifying child options in reopen, Kevin Wolf, 2015/11/23
- [Qemu-block] [PATCH v2 10/21] block: reopen: Document option precedence and refactor accordingly, Kevin Wolf, 2015/11/23
- [Qemu-block] [PATCH v2 12/21] block: Split out parse_json_protocol(), Kevin Wolf, 2015/11/23
- [Qemu-block] [PATCH v2 08/21] block: Keep "driver" in bs->options, Kevin Wolf, 2015/11/23
- [Qemu-block] [PATCH v2 14/21] blockdev: Set 'format' indicates non-empty drive, Kevin Wolf, 2015/11/23