Re: [Qemu-block] [PATCH v2 for-2.7 4/8] block: Drop blk_new_with

qemu-block

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v2 for-2.7 4/8] block: Drop blk_new_with_bs()

From:	Kevin Wolf
Subject:	Re: [Qemu-block] [PATCH v2 for-2.7 4/8] block: Drop blk_new_with_bs()
Date:	Thu, 7 Apr 2016 14:14:40 +0200
User-agent:	Mutt/1.5.21 (2010-09-15)

Am 06.04.2016 um 19:57 hat Max Reitz geschrieben:
> Its only caller is blk_new_open(), so we can just inline it there.
> 
> Signed-off-by: Max Reitz <address@hidden>

Maybe mention that this isn't pure code motion, but that you switch to a
bdrv_open() call with a NULL BDS. Either way:

Reviewed-by: Kevin Wolf <address@hidden>

[Prev in Thread]

Current Thread

[Next in Thread]

[Qemu-block] [PATCH v2 for-2.7 1/8] block: Drop useless bdrv_new() call, (continued)
- [Qemu-block] [PATCH v2 for-2.7 1/8] block: Drop useless bdrv_new() call, Max Reitz, 2016/04/06
  - Re: [Qemu-block] [PATCH v2 for-2.7 1/8] block: Drop useless bdrv_new() call, Alberto Garcia, 2016/04/07
  - Re: [Qemu-block] [PATCH v2 for-2.7 1/8] block: Drop useless bdrv_new() call, Kevin Wolf, 2016/04/07
- [Qemu-block] [PATCH v2 for-2.7 2/8] block: Let bdrv_open_inherit() return the snapshot, Max Reitz, 2016/04/06
  - Re: [Qemu-block] [PATCH v2 for-2.7 2/8] block: Let bdrv_open_inherit() return the snapshot, Kevin Wolf, 2016/04/07
    - Re: [Qemu-block] [PATCH v2 for-2.7 2/8] block: Let bdrv_open_inherit() return the snapshot, Max Reitz, 2016/04/08
    - Re: [Qemu-block] [PATCH v2 for-2.7 2/8] block: Let bdrv_open_inherit() return the snapshot, Kevin Wolf, 2016/04/08
- [Qemu-block] [PATCH v2 for-2.7 3/8] tests: Drop BDS from test-throttle.c, Max Reitz, 2016/04/06
  - Re: [Qemu-block] [PATCH v2 for-2.7 3/8] tests: Drop BDS from test-throttle.c, Kevin Wolf, 2016/04/07
- [Qemu-block] [PATCH v2 for-2.7 4/8] block: Drop blk_new_with_bs(), Max Reitz, 2016/04/06
  - Re: [Qemu-block] [PATCH v2 for-2.7 4/8] block: Drop blk_new_with_bs(), Kevin Wolf <=
- [Qemu-block] [PATCH v2 for-2.7 5/8] block: Drop bdrv_new_root(), Max Reitz, 2016/04/06
  - Re: [Qemu-block] [PATCH v2 for-2.7 5/8] block: Drop bdrv_new_root(), Kevin Wolf, 2016/04/07
- [Qemu-block] [PATCH v2 for-2.7 8/8] block: Drop bdrv_parent_cb_...() from bdrv_close(), Max Reitz, 2016/04/06
  - Re: [Qemu-block] [PATCH v2 for-2.7 8/8] block: Drop bdrv_parent_cb_...() from bdrv_close(), Kevin Wolf, 2016/04/07
- [Qemu-block] [PATCH v2 for-2.7 7/8] block: Assert !bs->refcnt in bdrv_close(), Max Reitz, 2016/04/06
  - Re: [Qemu-block] [PATCH v2 for-2.7 7/8] block: Assert !bs->refcnt in bdrv_close(), Kevin Wolf, 2016/04/07
- [Qemu-block] [PATCH v2 for-2.7 6/8] block: Make bdrv_open() return a BDS, Max Reitz, 2016/04/06
  - Re: [Qemu-block] [PATCH v2 for-2.7 6/8] block: Make bdrv_open() return a BDS, Kevin Wolf, 2016/04/07

Prev by Date: Re: [Qemu-block] [PATCH v2 for-2.7 3/8] tests: Drop BDS from test-throttle.c
Next by Date: Re: [Qemu-block] [PATCH v2 for-2.7 5/8] block: Drop bdrv_new_root()
Previous by thread: [Qemu-block] [PATCH v2 for-2.7 4/8] block: Drop blk_new_with_bs()
Next by thread: [Qemu-block] [PATCH v2 for-2.7 5/8] block: Drop bdrv_new_root()
Index(es):
- Date
- Thread