[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [RFC PATCH] block: Crude initial implement
From: |
no-reply |
Subject: |
Re: [Qemu-block] [Qemu-devel] [RFC PATCH] block: Crude initial implementation of -blockdev |
Date: |
Wed, 1 Feb 2017 09:15:07 -0800 (PST) |
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Type: series
Subject: [Qemu-devel] [RFC PATCH] block: Crude initial implementation of
-blockdev
Message-id: address@hidden
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/address@hidden -> patchew/address@hidden
- [tag update] patchew/address@hidden -> patchew/address@hidden
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
7f41650 block: Crude initial implementation of -blockdev
=== OUTPUT BEGIN ===
Checking PATCH 1/1: block: Crude initial implementation of -blockdev...
ERROR: line over 90 characters
#60: FILE: vl.c:2976:
+ QSIMPLEQ_HEAD(, BlockdevOptions_queue) bdo_queue =
QSIMPLEQ_HEAD_INITIALIZER(bdo_queue);
ERROR: do not use C99 // comments
#74: FILE: vl.c:3124:
+ // TODO get error out of parser
total: 2 errors, 0 warnings, 74 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden