Re: [Qemu-block] [Qemu-devel] [PATCH v5 0/3] Fix qemu-io return value on failure

[Max Reitz]

On 01.02.2017 01:31, Nir Soffer wrote:
> This series fix qemu-io to fail with non zero exit code when failing to open
> the file.
> 
> Changes since v4:
> - Added _unsupported_fmt helper
> - Test any format except raw, instead of only raw
> - Don't test stderr content, depends on the format
> - New test move to 174 since 173 is pending
> - Private copyright for new test
> - Fix commit message issues
> 
> Changes since v3:
> - Add cover letter
> - Squash the tests fix with the behavior change, so git bisect landing on the
>   change in behavior does not hit unnecessarily-broken tests.
> 
> Tested by running qemu-io manually and by running tests/check-block.sh.
> Note that test 059 has one unrelated test failure.
> 
> Nir Soffer (3):
>   qemu-io: Return non-zero exit code on failure
>   qemu-iotests: Add _unsupported_fmt helper
>   qemu-io: Add failure regression tests
> 
>  qemu-io.c                    |  8 ++++--
>  tests/qemu-iotests/059.out   |  3 ---
>  tests/qemu-iotests/070.out   |  1 -
>  tests/qemu-iotests/075.out   |  7 ------
>  tests/qemu-iotests/076.out   |  3 ---
>  tests/qemu-iotests/078.out   |  6 -----
>  tests/qemu-iotests/080.out   | 18 --------------
>  tests/qemu-iotests/083.out   | 17 -------------
>  tests/qemu-iotests/088.out   |  6 -----
>  tests/qemu-iotests/092.out   | 12 ---------
>  tests/qemu-iotests/116.out   |  7 ------
>  tests/qemu-iotests/131.out   |  1 -
>  tests/qemu-iotests/140.out   |  1 -
>  tests/qemu-iotests/174       | 59 
> ++++++++++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/174.out   |  7 ++++++
>  tests/qemu-iotests/common.rc | 11 +++++++++
>  tests/qemu-iotests/group     |  1 +
>  17 files changed, 84 insertions(+), 84 deletions(-)
>  create mode 100755 tests/qemu-iotests/174
>  create mode 100644 tests/qemu-iotests/174.out

Thanks, I've applied the series to my block tree:

https://github.com/XanClic/qemu/commits/block

Max

signature.asc
Description: OpenPGP digital signature