[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v15 08/25] block: introduce auto-loading bitmaps
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH v15 08/25] block: introduce auto-loading bitmaps |
Date: |
Thu, 16 Feb 2017 12:25:06 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 15.02.2017 um 11:10 hat Vladimir Sementsov-Ogievskiy geschrieben:
> Auto loading bitmaps are bitmaps stored in the disk image, which should
> be loaded when the image is opened and become BdrvDirtyBitmaps for the
> corresponding drive.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> Reviewed-by: John Snow <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>
Why do we need a new BlockDriver callback and special code for it in
bdrv_open_common()? The callback is only ever called immediately after
.bdrv_open/.bdrv_file_open, so can't the drivers just do this internally
in their .bdrv_open implementation? Even more so because qcow2 is the
only driver that supports this callback.
Kevin
- Re: [Qemu-block] [Qemu-devel] [PATCH v15 15/25] qcow2: add .bdrv_can_store_new_dirty_bitmap, (continued)
[Qemu-block] [PATCH v15 08/25] block: introduce auto-loading bitmaps, Vladimir Sementsov-Ogievskiy, 2017/02/15
- Re: [Qemu-block] [PATCH v15 08/25] block: introduce auto-loading bitmaps,
Kevin Wolf <=
- Re: [Qemu-block] [PATCH v15 08/25] block: introduce auto-loading bitmaps, Kevin Wolf, 2017/02/16
- Re: [Qemu-block] [PATCH v15 08/25] block: introduce auto-loading bitmaps, Vladimir Sementsov-Ogievskiy, 2017/02/17
- Re: [Qemu-block] [PATCH v15 08/25] block: introduce auto-loading bitmaps, Kevin Wolf, 2017/02/17
- Re: [Qemu-block] [PATCH v15 08/25] block: introduce auto-loading bitmaps, Vladimir Sementsov-Ogievskiy, 2017/02/17
- Re: [Qemu-block] [PATCH v15 08/25] block: introduce auto-loading bitmaps, Kevin Wolf, 2017/02/17
- Re: [Qemu-block] [PATCH v15 08/25] block: introduce auto-loading bitmaps, Denis V. Lunev, 2017/02/17
- Re: [Qemu-block] [PATCH v15 08/25] block: introduce auto-loading bitmaps, Kevin Wolf, 2017/02/17
- Re: [Qemu-block] [PATCH v15 08/25] block: introduce auto-loading bitmaps, Denis V. Lunev, 2017/02/17
- Re: [Qemu-block] [PATCH v15 08/25] block: introduce auto-loading bitmaps, Kevin Wolf, 2017/02/17
- Re: [Qemu-block] [PATCH v15 08/25] block: introduce auto-loading bitmaps, Vladimir Sementsov-Ogievskiy, 2017/02/17