[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v5 17/18] block: remove all encryption handling
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-block] [PATCH v5 17/18] block: remove all encryption handling APIs |
Date: |
Tue, 21 Feb 2017 15:28:25 +0100 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Tue 21 Feb 2017 12:55:11 PM CET, Daniel P. Berrange wrote:
> @@ -2244,24 +2240,8 @@ void qmp_block_passwd(bool has_device, const char
> *device,
> bool has_node_name, const char *node_name,
> const char *password, Error **errp)
> {
> - Error *local_err = NULL;
> - BlockDriverState *bs;
> - AioContext *aio_context;
> -
> - bs = bdrv_lookup_bs(has_device ? device : NULL,
> - has_node_name ? node_name : NULL,
> - &local_err);
> - if (local_err) {
> - error_propagate(errp, local_err);
> - return;
> - }
> -
> - aio_context = bdrv_get_aio_context(bs);
> - aio_context_acquire(aio_context);
> -
> - bdrv_add_key(bs, password, errp);
> -
> - aio_context_release(aio_context);
> + error_setg(errp,
> + "Setting block passwords directly is no longer supported");
> }
Shouldn't you also update the command description in block-core.json and
hmp-commands.hx ?
Berto
- Re: [Qemu-block] [PATCH v5 12/18] qcow2: extend specification to cover LUKS encryption, (continued)
- [Qemu-block] [PATCH v5 11/18] qcow2: convert QCow2 to use QCryptoBlock for encryption, Daniel P. Berrange, 2017/02/21
- [Qemu-block] [PATCH v5 15/18] iotests: enable tests 134 and 158 to work with qcow (v1), Daniel P. Berrange, 2017/02/21
- [Qemu-block] [PATCH v5 14/18] qcow2: add iotests to cover LUKS encryption support, Daniel P. Berrange, 2017/02/21
- [Qemu-block] [PATCH v5 13/18] qcow2: add support for LUKS encryption format, Daniel P. Berrange, 2017/02/21
- [Qemu-block] [PATCH v5 16/18] block: rip out all traces of password prompting, Daniel P. Berrange, 2017/02/21
- [Qemu-block] [PATCH v5 17/18] block: remove all encryption handling APIs, Daniel P. Berrange, 2017/02/21
- Re: [Qemu-block] [PATCH v5 17/18] block: remove all encryption handling APIs,
Alberto Garcia <=
- [Qemu-block] [PATCH v5 18/18] block: pass option prefix down to crypto layer, Daniel P. Berrange, 2017/02/21