[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH 22/54] block: Request real permissions in bdrv_attac
From: |
Kevin Wolf |
Subject: |
[Qemu-block] [PATCH 22/54] block: Request real permissions in bdrv_attach_child() |
Date: |
Tue, 21 Feb 2017 15:58:18 +0100 |
Now that all block drivers with children tell us what permissions they
need from each of their children, bdrv_attach_child() can use this
information and make the right requirements while trying to attach new
children.
Signed-off-by: Kevin Wolf <address@hidden>
---
block.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/block.c b/block.c
index 1c5f211..054e6f0 100644
--- a/block.c
+++ b/block.c
@@ -1659,10 +1659,14 @@ BdrvChild *bdrv_attach_child(BlockDriverState
*parent_bs,
Error **errp)
{
BdrvChild *child;
+ uint64_t perm, shared_perm;
+
+ assert(parent_bs->drv);
+ parent_bs->drv->bdrv_child_perm(parent_bs, NULL, child_role,
+ 0, BLK_PERM_ALL, &perm, &shared_perm);
- /* FIXME Use real permissions */
child = bdrv_root_attach_child(child_bs, child_name, child_role,
- 0, BLK_PERM_ALL, parent_bs, errp);
+ perm, shared_perm, parent_bs, errp);
if (child == NULL) {
return NULL;
}
--
1.8.3.1
- Re: [Qemu-block] [PATCH 18/54] block: Default .bdrv_child_perm() for format drivers, (continued)
[Qemu-block] [PATCH 17/54] block: Request child permissions in filter drivers, Kevin Wolf, 2017/02/21
[Qemu-block] [PATCH 19/54] block: Request child permissions in format drivers, Kevin Wolf, 2017/02/21
[Qemu-block] [PATCH 20/54] vvfat: Implement .bdrv_child_perm(), Kevin Wolf, 2017/02/21
[Qemu-block] [PATCH 22/54] block: Request real permissions in bdrv_attach_child(),
Kevin Wolf <=
[Qemu-block] [PATCH 21/54] block: Require .bdrv_child_perm() with child nodes, Kevin Wolf, 2017/02/21
[Qemu-block] [PATCH 23/54] block: Add permissions to BlockBackend, Kevin Wolf, 2017/02/21
[Qemu-block] [PATCH 27/54] block: Request real permissions in blk_new_open(), Kevin Wolf, 2017/02/21
[Qemu-block] [PATCH 24/54] block: Add permissions to blk_new(), Kevin Wolf, 2017/02/21