[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 10/54] vvfat: Use opened node as backing file
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH 10/54] vvfat: Use opened node as backing file |
Date: |
Wed, 22 Feb 2017 14:26:17 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 21.02.2017 15:58, Kevin Wolf wrote:
> We should not try to assign a not yet opened node as the backing file,
> because as soon as the permission system is added it will fail. The
> just added bdrv_new_open_driver() function is the right tool to open a
> file with an internal driver, use it.
>
> In case anyone wonders whether that magic fake backing file to trigger a
> special action on 'commit' actually works today: No, not for me. One
> reason is that we've been adding a raw format driver on top for several
> years now and raw doesn't support commit. Other reasons include that the
> backing file isn't writable and the driver doesn't support reopen, and
> it's also size 0 and the driver doesn't support bdrv_truncate. All of
> these are easily fixable, but then 'commit' ended up in an infinite loop
> deep in the vvfat code for me, so I thought I'd best leave it alone. I'm
> not really sure what it was supposed to do anyway.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/vvfat.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [PATCH 05/54] block: Attach bs->file only during .bdrv_open(), (continued)
- [Qemu-block] [PATCH 07/54] block: Use BlockBackend for image probing, Kevin Wolf, 2017/02/21
- [Qemu-block] [PATCH 01/54] blockdev: Use BlockBackend to resize in qmp_block_resize(), Kevin Wolf, 2017/02/21
- [Qemu-block] [PATCH 08/54] block: Factor out bdrv_open_driver(), Kevin Wolf, 2017/02/21
- [Qemu-block] [PATCH 09/54] block: Add bdrv_new_open_driver(), Kevin Wolf, 2017/02/21
- [Qemu-block] [PATCH 10/54] vvfat: Use opened node as backing file, Kevin Wolf, 2017/02/21
- [Qemu-block] [PATCH 12/54] block: Add op blocker permission constants, Kevin Wolf, 2017/02/21
- [Qemu-block] [PATCH 14/54] block: Let callers request permissions when attaching a child node, Kevin Wolf, 2017/02/21
- [Qemu-block] [PATCH 11/54] tests: Use opened block node for block job tests, Kevin Wolf, 2017/02/21