[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v4 7/8] nbd: Implement NBD_INFO_BLOCK_SIZE on se
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-block] [PATCH v4 7/8] nbd: Implement NBD_INFO_BLOCK_SIZE on server |
Date: |
Wed, 22 Feb 2017 17:51:10 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 21/02/2017 03:42, Eric Blake wrote:
> + /* Send NBD_INFO_BLOCK_SIZE always, but tweak the minimum size
> + * according to whether the client requested it, and according to
> + * whether this is OPT_INFO or OPT_GO. */
> + /* minimum - 1 for back-compat, or 512 if client is new enough.
> + * TODO: consult blk_bs(blk)->request_align? */
> + sizes[0] = (opt == NBD_OPT_INFO || blocksize) ? BDRV_SECTOR_SIZE : 1;
> + /* preferred - At least 4096, but larger as appropriate. */
> + sizes[1] = MAX(blk_get_opt_transfer(exp->blk), 4096);
Can we just say zero if the preferred transfer size is unknown?
Apart from this, it looks good.
Paolo
> + /* maximum - At most 32M, but smaller as appropriate. */
> + sizes[2] = MIN(blk_get_max_transfer(exp->blk), NBD_MAX_BUFFER_SIZE);
> + TRACE("advertising minimum 0x%" PRIx32 ", preferred 0x%" PRIx32
> + ", maximum 0x%" PRIx32, sizes[0], sizes[1], sizes[2]);
- [Qemu-block] [PATCH v4 0/8] Implement NBD_OPT_GO, block size advertisement, Eric Blake, 2017/02/20
- [Qemu-block] [PATCH v4 1/8] nbd/client: fix drop_sync [CVE-2017-2630], Eric Blake, 2017/02/20
- [Qemu-block] [PATCH v4 3/8] block: Add blk_get_opt_transfer(), Eric Blake, 2017/02/20
- [Qemu-block] [PATCH v4 2/8] nbd: Create struct for tracking export info, Eric Blake, 2017/02/20
- [Qemu-block] [PATCH v4 7/8] nbd: Implement NBD_INFO_BLOCK_SIZE on server, Eric Blake, 2017/02/20
- Re: [Qemu-block] [PATCH v4 7/8] nbd: Implement NBD_INFO_BLOCK_SIZE on server,
Paolo Bonzini <=
- Re: [Qemu-block] [PATCH v4 7/8] nbd: Implement NBD_INFO_BLOCK_SIZE on server, Eric Blake, 2017/02/22
- Re: [Qemu-block] [PATCH v4 7/8] nbd: Implement NBD_INFO_BLOCK_SIZE on server, Paolo Bonzini, 2017/02/22
- Re: [Qemu-block] [PATCH v4 7/8] nbd: Implement NBD_INFO_BLOCK_SIZE on server, Eric Blake, 2017/02/22
- Re: [Qemu-block] [PATCH v4 7/8] nbd: Implement NBD_INFO_BLOCK_SIZE on server, Paolo Bonzini, 2017/02/23
- Re: [Qemu-block] [PATCH v4 7/8] nbd: Implement NBD_INFO_BLOCK_SIZE on server, Eric Blake, 2017/02/23
[Qemu-block] [PATCH v4 6/8] nbd: Implement NBD_OPT_GO on client, Eric Blake, 2017/02/20
[Qemu-block] [PATCH v4 4/8] nbd: Expose and debug more NBD constants, Eric Blake, 2017/02/20
[Qemu-block] [PATCH v4 5/8] nbd: Implement NBD_OPT_GO on server, Eric Blake, 2017/02/20
[Qemu-block] [PATCH v4 8/8] nbd: Implement NBD_INFO_BLOCK_SIZE on client, Eric Blake, 2017/02/20