Re: [Qemu-block] [PATCH RFC v2 1/1] block: pass the right options for BlockDriver.bdrv_open

[Max Reitz]

On 28.03.2017 08:39, Dong Jia Shi wrote:
> * Max Reitz <address@hidden> [2017-03-27 17:27:16 +0200]:

[...]

>> (1) Remove every option in "options" that has a "file." prefix before
>> the qdict_put() call.
>>
>> (2) Use bdrv_unref_child(bs->file) instead of bdrv_unref(bs->file->bs).
> :> You must mean:
> bdrv_unref_child(bs, bs->file);

Yes, right. :-)

>> I guess it should work with those changes. At least I hope it will.
> Yes, with my test results, it works!
> 
>>
>> By the way, the easiest way to do (1) is probably:
>>
>> QDict *file_options;
>>
>> qdict_extract_subqdict(options, &file_options, "file.");
>> QDECREF(file_options);
> Cool. I adopted your code and it works well.
> 
> Thanks for these very detailed analysis and the code example.

No problem.

> Mind if I add a:
> Suggested-by: Max Reitz <address@hidden>
> in the following version?

Feel free to, but it's not necessary. That was just normal reviewing work.

Max

signature.asc
Description: OpenPGP digital signature