[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [for-2.9 1/8] nbd sockets vnc: Mark problematic address
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-block] [for-2.9 1/8] nbd sockets vnc: Mark problematic address family tests TODO |
|
Date: |
Wed, 29 Mar 2017 14:51:07 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 03/29/2017 11:45 AM, Markus Armbruster wrote:
> Certain features make sense only with certain address families. For
> instance, passing file descriptors requires AF_UNIX. Testing
> SocketAddress's saddr->type == SOCKET_ADDRESS_KIND_UNIX is obvious,
> but problematic: it can't recognize AF_UNIX when type ==
> SOCKET_ADDRESS_KIND_FD.
>
> Mark such tests of saddr->type TODO. We may want to check the address
> family with getsockname() there.
>
> Cc: Paolo Bonzini <address@hidden>
> Cc: Gerd Hoffmann <address@hidden>
> Cc: Daniel P. Berrange <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [Qemu-devel] [for-2.9 6/8] qapi-schema: SocketAddressFlat variants 'vsock' and 'fd', (continued)
[Qemu-block] [for-2.9 5/8] gluster: Prepare for SocketAddressFlat extension, Markus Armbruster, 2017/03/29
[Qemu-block] [for-2.9 3/8] io vnc sockets: Clean up SocketAddressKind switches, Markus Armbruster, 2017/03/29
[Qemu-block] [for-2.9 1/8] nbd sockets vnc: Mark problematic address family tests TODO, Markus Armbruster, 2017/03/29
[Qemu-block] [for-2.9 8/8] sheepdog: Fix blockdev-add, Markus Armbruster, 2017/03/29
[Qemu-block] [for-2.9 2/8] char: Fix socket with "type": "vsock" address, Markus Armbruster, 2017/03/29
Re: [Qemu-block] [for-2.9 2/8] char: Fix socket with "type": "vsock" address, Stefan Hajnoczi, 2017/03/29