[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH for-2.9] iscsi: Fix iscsi_create
|
From: |
Max Reitz |
|
Subject: |
Re: [Qemu-block] [PATCH for-2.9] iscsi: Fix iscsi_create |
|
Date: |
Tue, 11 Apr 2017 15:18:35 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 |
On 10.04.2017 09:54, Fam Zheng wrote:
> Since d5895fcb (iscsi: Split URL into individual options), creating
> qcow2 image on an iscsi LUN fails:
>
> qemu-img create -f qcow2 iscsi://$SERVER/$IQN/0 1G
> qemu-img: iscsi://$SERVER/$IQN/0: Could not create image: Invalid
> argument
>
> The problem is iscsi_open now expects that transport_name, portal and
> target are already parsed into structured options by
> iscsi_parse_filename, but it is not called in iscsi_create.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> block/iscsi.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
Thanks, dropped the qdict_put() for "filename" and applied to my block
branch:
https://github.com/XanClic/qemu/commits/block
Max
signature.asc
Description: OpenPGP digital signature