Re: [Qemu-block] [PATCH] qemu_iotests: Remove _readlink()

[Max Reitz]

On 21.04.2017 10:01, Kevin Wolf wrote:
> It is unused.
> 
> Suggestetd-by: Fam Zheng <address@hidden>

*Suggested

And, since it now would be rude not to, with that fixed:

Reviewed-by: Max Reitz <address@hidden>

> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  tests/qemu-iotests/common.config | 18 ------------------
>  1 file changed, 18 deletions(-)
> 
> diff --git a/tests/qemu-iotests/common.config 
> b/tests/qemu-iotests/common.config
> index 1222e43..66f4e0b 100644
> --- a/tests/qemu-iotests/common.config
> +++ b/tests/qemu-iotests/common.config
> @@ -204,23 +204,5 @@ fi
>  
>  export SAMPLE_IMG_DIR
>  
> -_readlink()
> -{
> -    if [ $# -ne 1 ]; then
> -        echo "Usage: _readlink filename" 1>&2
> -        exit 1
> -    fi
> -
> -    perl -e "\$in=\"$1\";" -e '
> -    $lnk = readlink($in);
> -    if ($lnk =~ m!^/.*!) {
> -        print "$lnk\n";
> -    }
> -    else {
> -        chomp($dir = `dirname $in`);
> -        print "$dir/$lnk\n";
> -    }'
> -}
> -
>  # make sure this script returns success
>  true
>

signature.asc
Description: OpenPGP digital signature