[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v10 08/17] qemu-io: Switch 'map' output to byte-
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH v10 08/17] qemu-io: Switch 'map' output to byte-based reporting |
Date: |
Fri, 28 Apr 2017 21:53:29 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 |
On 27.04.2017 03:46, Eric Blake wrote:
> Mixing byte offset and sector allocation counts is a bit
> confusing. Also, reporting n/m sectors, where m decreases
> according to the remaining size of the file, isn't really
> adding any useful information.
Since this map doesn't leave out any range in the image file -- not
really, no. :-)
> Update the output to use
> byte counts, and adjust the affected tests (./check -qcow2 102,
> ./check -vpc 146).
>
> Signed-off-by: Eric Blake <address@hidden>
>
> ---
> v10: rebase to updated test 179
> v9: new patch
> ---
> qemu-io-cmds.c | 5 ++---
> tests/qemu-iotests/102.out | 4 ++--
> tests/qemu-iotests/146.out | 30 +++++++++++++++---------------
> tests/qemu-iotests/179.out | 22 +++++++++++-----------
> 4 files changed, 30 insertions(+), 31 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v10 05/17] iotests: Add test 179 to cover write zeroes with unmap, (continued)
[Qemu-block] [PATCH v10 08/17] qemu-io: Switch 'map' output to byte-based reporting, Eric Blake, 2017/04/26
- Re: [Qemu-block] [PATCH v10 08/17] qemu-io: Switch 'map' output to byte-based reporting,
Max Reitz <=
[Qemu-block] [PATCH v10 09/17] qcow2: Optimize write zero of unaligned tail cluster, Eric Blake, 2017/04/26
[Qemu-block] [PATCH v10 12/17] blkdebug: Sanity check block layer guarantees, Eric Blake, 2017/04/26
[Qemu-block] [PATCH v10 13/17] blkdebug: Refactor error injection, Eric Blake, 2017/04/26
[Qemu-block] [PATCH v10 15/17] blkdebug: Simplify override logic, Eric Blake, 2017/04/26
[Qemu-block] [PATCH v10 14/17] blkdebug: Add pass-through write_zero and discard support, Eric Blake, 2017/04/26
[Qemu-block] [PATCH v10 10/17] qcow2: Assert that cluster operations are aligned, Eric Blake, 2017/04/26
[Qemu-block] [PATCH v10 16/17] blkdebug: Add ability to override unmap geometries, Eric Blake, 2017/04/26