[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callback
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn |
Date: |
Wed, 5 Jul 2017 16:44:36 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 05/07/2017 16:21, Marc-André Lureau wrote:
>>
>> They are, but it's an implementation detail. Why is this patch necessary?
> I didn't think this would be controversial :) well, the checks I added to
> clang verify function pointer share the coroutine attribute.
>
> The function themself are/need to be coroutine_fn (as they will call
> coroutine_fn too)
It's not controversial, I would not have expected the functions to call
coroutine_fn. :) How do they do that?
Paolo