[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v2 4/9] block/qapi: Use blk_all_next() for query-blo
From: |
Kevin Wolf |
Subject: |
[Qemu-block] [PATCH v2 4/9] block/qapi: Use blk_all_next() for query-block |
Date: |
Thu, 13 Jul 2017 13:41:30 +0200 |
This patch replaces the blk_next() loop in query-block by a
blk_all_next() one so that we also get access to BlockBackends that
aren't owned by the monitor. For now, the next thing we do is check
whether each BB has a name, so there is no semantic difference.
Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
block/qapi.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/block/qapi.c b/block/qapi.c
index 705cd11..2f86c79 100644
--- a/block/qapi.c
+++ b/block/qapi.c
@@ -472,8 +472,14 @@ BlockInfoList *qmp_query_block(Error **errp)
BlockBackend *blk;
Error *local_err = NULL;
- for (blk = blk_next(NULL); blk; blk = blk_next(blk)) {
- BlockInfoList *info = g_malloc0(sizeof(*info));
+ for (blk = blk_all_next(NULL); blk; blk = blk_all_next(blk)) {
+ BlockInfoList *info;
+
+ if (!*blk_name(blk)) {
+ continue;
+ }
+
+ info = g_malloc0(sizeof(*info));
bdrv_query_info(blk, &info->value, &local_err);
if (local_err) {
error_propagate(errp, local_err);
--
1.8.3.1
- [Qemu-block] [PATCH v2 0/9] block: -device drive=<node-name> fixes, Kevin Wolf, 2017/07/13
- [Qemu-block] [PATCH v2 1/9] block: Make blk_get_attached_dev_id() public, Kevin Wolf, 2017/07/13
- [Qemu-block] [PATCH v2 2/9] block/qapi: Add qdev device name to query-block, Kevin Wolf, 2017/07/13
- [Qemu-block] [PATCH v2 3/9] block: Make blk_all_next() public, Kevin Wolf, 2017/07/13
- [Qemu-block] [PATCH v2 5/9] block: List anonymous device BBs in query-block, Kevin Wolf, 2017/07/13
- [Qemu-block] [PATCH v2 4/9] block/qapi: Use blk_all_next() for query-block,
Kevin Wolf <=
- [Qemu-block] [PATCH v2 6/9] ide: bdrv_attach_dev() for empty CD-ROM, Kevin Wolf, 2017/07/13
- [Qemu-block] [PATCH v2 7/9] scsi-disk: bdrv_attach_dev() for empty CD-ROM, Kevin Wolf, 2017/07/13
- [Qemu-block] [PATCH v2 9/9] qemu-iotests: Test unplug of -device without drive, Kevin Wolf, 2017/07/13
- [Qemu-block] [PATCH v2 8/9] qemu-iotests: Test 'info block', Kevin Wolf, 2017/07/13
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/9] block: -device drive=<node-name> fixes, John Snow, 2017/07/13
- Re: [Qemu-block] [PATCH v2 0/9] block: -device drive=<node-name> fixes, Kevin Wolf, 2017/07/17