Re: [Qemu-block] [PATCH v5 7/9] nbd: Implement NBD_OPT_GO on client

[Eric Blake]

On 07/17/2017 03:31 AM, Kevin Wolf wrote:
> Am 07.07.2017 um 22:30 hat Eric Blake geschrieben:
>> NBD_OPT_EXPORT_NAME is lousy: per the NBD protocol, any failure
>> requires the server to close the connection rather than report an
>> error to us.  Therefore, upstream NBD recently added NBD_OPT_GO as
>> the improved version of the option that does what we want [1]: it
>> reports sane errors on failures, and on success provides at least
>> as much info as NBD_OPT_EXPORT_NAME.
>>

> 
> This breaks qemu-iotests 140 and 143:

Urrgh, and I even ran into it locally last week after posting my v1, and
had it on my list to fix before posting v2, when Paolo committed my v1
to make softfreeze before going on PTO this week. I will post the fix
later today (I already have a couple other NBD patches pending, so my
plan is to submit a PULL request by the end of my day with all of the
fixes).

> 
> -can't open device nbd+unix:///drv?socket=TEST_DIR/nbd: No export with name 
> 'drv' available
> +can't open device nbd+unix:///drv?socket=TEST_DIR/nbd: Requested export not 
> available for option 7 (go)
> +export 'drv' not present
> 
> We could just update the reference output, but I actually believe the
> old error message was better.

One line is indeed better than two; I'm still playing with the easiest
way to get the desired output.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature