[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 0/3] build configuration query tool
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 0/3] build configuration query tool and conditional (qemu-io)test skip |
Date: |
Wed, 26 Jul 2017 18:58:08 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Tue, Jul 25, 2017 at 12:16:13PM -0400, Cleber Rosa wrote:
> On 07/25/2017 11:49 AM, Stefan Hajnoczi wrote:
> > On Fri, Jul 21, 2017 at 10:21:24AM -0400, Cleber Rosa wrote:
> >> On 07/21/2017 10:01 AM, Daniel P. Berrange wrote:
> >>> On Fri, Jul 21, 2017 at 01:33:25PM +0100, Stefan Hajnoczi wrote:
> >>>> On Thu, Jul 20, 2017 at 11:47:27PM -0400, Cleber Rosa wrote:
> >> Without the static capabilities defined, the dynamic check would be
> >> influenced by the run time environment. It would really mean "qemu-io
> >> running on this environment (filesystem?) can do native aio". Again,
> >> that's not the best type of information to depend on when writing tests.
> >
> > Can you explain this more?
> >
> > It seems logical to me that if qemu-io in this environment cannot do
> > aio=native then we must skip those tests.
> >
> > Stefan
> >
>
> OK, let's abstract a bit more. Let's take this part of your statement:
>
> "if qemu-io in this environment cannot do aio=native"
>
> Let's call that a feature check. Depending on how the *feature check*
> is written, a negative result may hide a test failure, because it would
> now be skipped.
You are saying a pass->skip transition can hide a failure but ./check
tracks skipped tests. See tests/qemu-iotests/check.log for a
pass/fail/skip history.
It is the job of the CI system to flag up pass/fail/skip transitions.
You're no worse off using feature tests.
Stefan
signature.asc
Description: PGP signature
- [Qemu-block] [PATCH 0/3] build configuration query tool and conditional (qemu-io)test skip, Cleber Rosa, 2017/07/21
- Re: [Qemu-block] [Qemu-devel] [PATCH 0/3] build configuration query tool and conditional (qemu-io)test skip, no-reply, 2017/07/21
- Re: [Qemu-block] [Qemu-devel] [PATCH 0/3] build configuration query tool and conditional (qemu-io)test skip, Stefan Hajnoczi, 2017/07/21
- Re: [Qemu-block] [Qemu-devel] [PATCH 0/3] build configuration query tool and conditional (qemu-io)test skip, Cleber Rosa, 2017/07/21
- Re: [Qemu-block] [Qemu-devel] [PATCH 0/3] build configuration query tool and conditional (qemu-io)test skip, Daniel P. Berrange, 2017/07/21
- Re: [Qemu-block] [Qemu-devel] [PATCH 0/3] build configuration query tool and conditional (qemu-io)test skip, Cleber Rosa, 2017/07/21
- Re: [Qemu-block] [Qemu-devel] [PATCH 0/3] build configuration query tool and conditional (qemu-io)test skip, Stefan Hajnoczi, 2017/07/25
- Re: [Qemu-block] [Qemu-devel] [PATCH 0/3] build configuration query tool and conditional (qemu-io)test skip, Cleber Rosa, 2017/07/25
- Re: [Qemu-block] [Qemu-devel] [PATCH 0/3] build configuration query tool and conditional (qemu-io)test skip, Daniel P. Berrange, 2017/07/25
- Re: [Qemu-block] [Qemu-devel] [PATCH 0/3] build configuration query tool and conditional (qemu-io)test skip, Cleber Rosa, 2017/07/25
- Re: [Qemu-block] [Qemu-devel] [PATCH 0/3] build configuration query tool and conditional (qemu-io)test skip,
Stefan Hajnoczi <=
- Re: [Qemu-block] [Qemu-devel] [PATCH 0/3] build configuration query tool and conditional (qemu-io)test skip, Cleber Rosa, 2017/07/26
- Re: [Qemu-block] [Qemu-devel] [PATCH 0/3] build configuration query tool and conditional (qemu-io)test skip, Stefan Hajnoczi, 2017/07/27
[Qemu-block] [PATCH 2/3] qemu-iotests: add _require_feature() function, Cleber Rosa, 2017/07/21
[Qemu-block] [PATCH 3/3] qemu-iotests: require CONFIG_LINUX_AIO for test 087, Cleber Rosa, 2017/07/21
[Qemu-block] [PATCH 1/3] scripts: introduce buildconf.py, Cleber Rosa, 2017/07/21