[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] block/null: Remove 'filename' option
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-block] [PATCH] block/null: Remove 'filename' option |
|
Date: |
Mon, 7 Aug 2017 16:02:27 +0200 |
|
User-agent: |
Mutt/1.8.3 (2017-05-23) |
Am 04.08.2017 um 16:56 hat Eric Blake geschrieben:
> On 08/04/2017 09:43 AM, Kevin Wolf wrote:
> > This option was only added to allow 'null-co://' and 'null-aio://' as
> > filenames, its value never served any actual purpose and was ignored.
> > Nevertheless it was accepted as '-drive driver=null,filename=foo'.
> >
> > The correct way to enable the protocol prefixes (and that without adding
> > a useless -drive option) is implementing .bdrv_parse_filename. This is
> > what this patch does.
> >
> > Technically, this is an incompatible change, but the null block driver
> > is only used for benchmarking, testing and debugging, and an option
> > without effect isn't likely to be used by anyone anyway, so no bad
> > effects are to be expected.
>
> Agreed with the analysis. Still, better to get it into 2.10 rather than
> going yet another release with the option available.
Makes sense. Applied to the block branch.
Kevin
signature.asc
Description: PGP signature