[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 3/4] qcow2: Drop debugging dump_refcounts()
From: |
Jeff Cody |
Subject: |
Re: [Qemu-block] [PATCH 3/4] qcow2: Drop debugging dump_refcounts() |
Date: |
Mon, 7 Aug 2017 19:33:59 -0400 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Mon, Aug 07, 2017 at 03:30:06PM -0500, Eric Blake wrote:
> It's been #if 0'd since its introduction in 2006, commit 585f8587.
> We can revive dead code if we need it, but in the meantime, it has
> bit-rotted (for example, not checking for failure in bdrv_getlength()).
>
> Signed-off-by: Eric Blake <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
> ---
> block/qcow2.c | 21 ---------------------
> 1 file changed, 21 deletions(-)
>
> diff --git a/block/qcow2.c b/block/qcow2.c
> index d7c600b5a2..99407403ea 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -3798,27 +3798,6 @@ static ImageInfoSpecific
> *qcow2_get_specific_info(BlockDriverState *bs)
> return spec_info;
> }
>
> -#if 0
> -static void dump_refcounts(BlockDriverState *bs)
> -{
> - BDRVQcow2State *s = bs->opaque;
> - int64_t nb_clusters, k, k1, size;
> - int refcount;
> -
> - size = bdrv_getlength(bs->file->bs);
> - nb_clusters = size_to_clusters(s, size);
> - for(k = 0; k < nb_clusters;) {
> - k1 = k;
> - refcount = get_refcount(bs, k);
> - k++;
> - while (k < nb_clusters && get_refcount(bs, k) == refcount)
> - k++;
> - printf("%" PRId64 ": refcount=%d nb=%" PRId64 "\n", k, refcount,
> - k - k1);
> - }
> -}
> -#endif
> -
> static int qcow2_save_vmstate(BlockDriverState *bs, QEMUIOVector *qiov,
> int64_t pos)
> {
> --
> 2.13.4
>
>
- Re: [Qemu-block] [PATCH 1/4] vpc: Check failure of bdrv_getlength(), (continued)