[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 2/4] IDE: test flush on empty CDROM
From: |
John Snow |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 2/4] IDE: test flush on empty CDROM |
Date: |
Tue, 8 Aug 2017 15:32:09 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 08/08/2017 03:20 PM, Eric Blake wrote:
> On 08/08/2017 12:57 PM, John Snow wrote:
>> From: Kevin Wolf <address@hidden>
>>
>> Signed-off-by: Kevin Wolf <address@hidden>
>> Signed-off-by: John Snow <address@hidden>
>> ---
>> tests/ide-test.c | 19 +++++++++++++++++++
>> 1 file changed, 19 insertions(+)
>>
>
>> +static void test_flush_empty_drive(void)
>> +{
>> + QPCIDevice *dev;
>> + QPCIBar bmdma_bar, ide_bar;
>> +
>> + ide_test_start("-device ide-cd,bus=ide.0");
>> + dev = get_pci_device(&bmdma_bar, &ide_bar);
>> +
>> + /* FLUSH CACHE command on device 0*/
>
> Space before */
>
> Reviewed-by: Eric Blake <address@hidden>
>
> I agree with your assessment of 1 and 2 being 2.10 material.
>
Yep, thanks. I just wanted to include Kevin's attempt at fixing the root
problem to make it clear that:
(A) The root problem is known and being worked on, but
(B) Is evidently not ready for prime time.
I'll stage 1 & 2 with your minor typo edit here, thank you.
--js
- [Qemu-block] [PATCH 0/4] IDE: Do not flush empty drives, John Snow, 2017/08/08
- [Qemu-block] [PATCH 1/4] IDE: Do not flush empty CDROM drives, John Snow, 2017/08/08
- [Qemu-block] [PATCH 2/4] IDE: test flush on empty CDROM, John Snow, 2017/08/08
- [Qemu-block] [PATCH 3/4] block-backend: shift in-flight counter to BB from BDS, John Snow, 2017/08/08
- [Qemu-block] [PATCH 4/4] block-backend: test flush op on empty backend, John Snow, 2017/08/08
- Re: [Qemu-block] [PATCH 0/4] IDE: Do not flush empty drives, Stefan Hajnoczi, 2017/08/09