[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 2/9] IDE: Add register hints to tra
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 2/9] IDE: Add register hints to tracing |
Date: |
Tue, 8 Aug 2017 15:05:39 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 08/08/2017 01:32 PM, John Snow wrote:
> Name the registers for tracing purposes.
>
> Signed-off-by: John Snow <address@hidden>
> ---
> hw/ide/core.c | 88
> +++++++++++++++++++++++++++++++++++++++++------------
> hw/ide/trace-events | 4 +--
> 2 files changed, 70 insertions(+), 22 deletions(-)
> - case 1:
> - ide_clear_hob(bus);
> + case ATA_IOPORT_WR_FEATURES:
> + ide_clear_hob(bus);
Cool, fixing tab damage in the process.
I did a similar improvement to NBD traces, and it's definitely worth it
to have traces include names in addition to numbers.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [Qemu-devel] [PATCH 7/9] AHCI: Rework IRQ constants, (continued)
[Qemu-block] [PATCH 3/9] IDE: add tracing for data ports, John Snow, 2017/08/08
[Qemu-block] [PATCH 2/9] IDE: Add register hints to tracing, John Snow, 2017/08/08
[Qemu-block] [PATCH 8/9] AHCI: pretty-print FIS to buffer instead of stderr, John Snow, 2017/08/08
[Qemu-block] [PATCH 6/9] AHCI: Replace DPRINTF with trace-events, John Snow, 2017/08/08
Re: [Qemu-block] [Qemu-devel] [PATCH 0/9] IDE: replace printfs with tracing, no-reply, 2017/08/08