Re: [Qemu-block] [PATCH v8 0/8] Optimize VMDK I/O by allocating multiple clusters

[Stefan Hajnoczi]

On Thu, Jul 27, 2017 at 3:33 PM, Ashijeet Acharya
<address@hidden> wrote:
> Previously posted series patches:
> v1 - http://lists.nongnu.org/archive/html/qemu-devel/2017-03/msg02044.html
> v2 - http://lists.nongnu.org/archive/html/qemu-devel/2017-03/msg05080.html
> v3 - http://lists.nongnu.org/archive/html/qemu-devel/2017-04/msg00074.html
> v4 - http://lists.nongnu.org/archive/html/qemu-devel/2017-04/msg03851.html
> v5 - http://lists.nongnu.org/archive/html/qemu-devel/2017-06/msg00929.html
> v6 - http://lists.nongnu.org/archive/html/qemu-devel/2017-06/msg00947.html
> v7 - http://lists.nongnu.org/archive/html/qemu-devel/2017-06/msg06600.html
>
> This series helps to optimize the I/O performance of VMDK driver.
>
> Patch 1 helps us to move vmdk_find_offset_in_cluster.
>
> Patch 2 & 3 perform a simple function re-naming tasks.
>
> Patch 4 is used to factor out metadata loading code and implement it in 
> separate
> functions. This will help us to avoid code duplication in future patches of 
> this
> series.
>
> Patch 5 helps to set the upper limit of the bytes handled in one cycle.
>
> Patch 6 adds new functions to help us allocate multiple clusters according to
> the size requested, perform COW if required and return the offset of the first
> newly allocated cluster.
>
> Patch 7 changes the metadata update code to update the L2 tables for multiple
> clusters at once.
>
> Patch 8 helps us to finally change vmdk_get_cluster_offset() to find cluster
> offset only as cluster allocation task is now handled by vmdk_alloc_clusters()
>
> Optimization test results:
>
> This patch series improves 128 KB sequential write performance to an
> empty VMDK file by 54%
>
> Benchmark command: ./qemu-img bench -w -c 1024 -s 128K -d 1 -t none -f
> vmdk test.vmdk
>
> Changes in v8:
> - fix minor variable naming issue in patch 6

Fam: Ping?

Ashijeet: Feel free to send a ping reply if no one reviews your
patches within a few days.