[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH for-2.10 v2 0/4] block: Fix non-shared storage migra
From: |
Fam Zheng |
Subject: |
[Qemu-block] [PATCH for-2.10 v2 0/4] block: Fix non-shared storage migration |
Date: |
Tue, 15 Aug 2017 21:07:36 +0800 |
v2: Don't leak blk->vmsh when BB is deleted before the callback is called.
[Stefan]
From stub functions, don't return g_malloc0(1) which is risky, return NULL.
[Eric]
"nbd-server-add -w" doesn't work when we are in "-incoming defer" state:
(qemu) nbd_server_add -w drive-virtio-disk0
Block node is read-only
Two problems are faced:
- nbd_export_new() calls bdrv_invalidate_cache() too late.
- bdrv_invalidate_cache() restores qdev permission (which are temporarily
masked by BlockBackend.disable_perm during INMIGRATE) too early.
Fix both, and add a regression iotest.
Fam Zheng (3):
stubs: Add vm state change handler stubs
block-backend: Defer shared_perm tightening migration completion
iotests: Add non-shared storage migration case 192
Kevin Wolf (1):
nbd: Fix order of bdrv_set_perm and bdrv_invalidate_cache
block/block-backend.c | 41 ++++++++++++++++++++++++++++
nbd/server.c | 20 +++++++-------
stubs/Makefile.objs | 1 +
stubs/change-state-handler.c | 14 ++++++++++
tests/qemu-iotests/192 | 63 ++++++++++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/192.out | 7 +++++
tests/qemu-iotests/group | 1 +
7 files changed, 138 insertions(+), 9 deletions(-)
create mode 100644 stubs/change-state-handler.c
create mode 100755 tests/qemu-iotests/192
create mode 100644 tests/qemu-iotests/192.out
--
2.13.4
- [Qemu-block] [PATCH for-2.10 v2 0/4] block: Fix non-shared storage migration,
Fam Zheng <=
- [Qemu-block] [PATCH for-2.10 v2 1/4] stubs: Add vm state change handler stubs, Fam Zheng, 2017/08/15
- [Qemu-block] [PATCH for-2.10 v2 2/4] nbd: Fix order of bdrv_set_perm and bdrv_invalidate_cache, Fam Zheng, 2017/08/15
- [Qemu-block] [PATCH for-2.10 v2 3/4] block-backend: Defer shared_perm tightening migration completion, Fam Zheng, 2017/08/15
- [Qemu-block] [PATCH for-2.10 v2 4/4] iotests: Add non-shared storage migration case 192, Fam Zheng, 2017/08/15
- Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10 v2 0/4] block: Fix non-shared storage migration, Christian Ehrhardt, 2017/08/18