[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] nbd-client: Fix regression when server sen
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
Re: [Qemu-block] [Qemu-devel] nbd-client: Fix regression when server sends garbage |
Date: |
Wed, 23 Aug 2017 18:21:09 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
23.08.2017 18:17, Eric Blake wrote:
On 08/23/2017 10:09 AM, Vladimir Sementsov-Ogievskiy wrote:
ping
We're still trying to round up last-minute patches for a 2.10-rc4 pull
request.
@@ -107,6 +107,9 @@ static coroutine_fn void
nbd_read_reply_entry(void *opaque)
qemu_coroutine_yield();
}
+ if (ret < 0) {
+ s->quit = true;
but on wrong handle ret is 0:
s/0/positive/
Is your issue fixed by Stefan's patch?
https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg04027.html
Yes it fixed, I'm now composing reply on it.
In fact, he listed a reproduction formula in his earlier attempt at it,
that demonstrates that we still had a hang possible with just what made
it into -rc3
https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg03853.html
--
Best regards,
Vladimir