[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v2 3/7] throttle: Make throttle_is_
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v2 3/7] throttle: Make throttle_is_valid() a bit less verbose |
Date: |
Tue, 29 Aug 2017 16:26:50 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 08/24/2017 08:24 AM, Alberto Garcia wrote:
> Use a pointer to the bucket instead of repeating cfg->buckets[i] all
> the time. This makes the code more concise and will help us expand the
> checks later and save a few line breaks.
>
> Signed-off-by: Alberto Garcia <address@hidden>
> ---
> util/throttle.c | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/util/throttle.c b/util/throttle.c
> index 9a6bda813c..bde56fe3de 100644
> --- a/util/throttle.c
> +++ b/util/throttle.c
> @@ -324,32 +324,31 @@ bool throttle_is_valid(ThrottleConfig *cfg, Error
> **errp)
> }
>
> for (i = 0; i < BUCKETS_COUNT; i++) {
> - if (cfg->buckets[i].avg < 0 ||
> - cfg->buckets[i].max < 0 ||
> - cfg->buckets[i].avg > THROTTLE_VALUE_MAX ||
> - cfg->buckets[i].max > THROTTLE_VALUE_MAX) {
> + LeakyBucket *bkt = &cfg->buckets[i];
> + if (bkt->avg < 0 || bkt->max < 0 ||
Up to the maintainer, but I'd include a blank line between declarations
and code.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v2 0/7] Misc throttle fixes, Alberto Garcia, 2017/08/24
- [Qemu-block] [PATCH v2 1/7] throttle: Fix wrong variable name in the header documentation, Alberto Garcia, 2017/08/24
- [Qemu-block] [PATCH v2 3/7] throttle: Make throttle_is_valid() a bit less verbose, Alberto Garcia, 2017/08/24
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 3/7] throttle: Make throttle_is_valid() a bit less verbose,
Eric Blake <=
- [Qemu-block] [PATCH v2 4/7] throttle: Remove throttle_fix_bucket() / throttle_unfix_bucket(), Alberto Garcia, 2017/08/24
- [Qemu-block] [PATCH v2 7/7] throttle: Test the valid range of config values, Alberto Garcia, 2017/08/24
- [Qemu-block] [PATCH v2 5/7] throttle: Make LeakyBucket.avg and LeakyBucket.max integer types, Alberto Garcia, 2017/08/24
- [Qemu-block] [PATCH v2 2/7] throttle: Update the throttle_fix_bucket() documentation, Alberto Garcia, 2017/08/24
- [Qemu-block] [PATCH v2 6/7] throttle: Make burst_length 64bit and add range checks, Alberto Garcia, 2017/08/24
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/7] Misc throttle fixes, Stefan Hajnoczi, 2017/08/29