Re: [Qemu-block] [PATCH] qemu-iotests: Add missing -machine accel=qtest

[Cornelia Huck]

On Thu,  7 Sep 2017 10:53:10 +0200
Kevin Wolf <address@hidden> wrote:

> A basic set of qemu options is initialised in ./common:
> 
>     export QEMU_OPTIONS="-nodefaults -machine accel=qtest"
> 
> However, two test cases (172 and 186) overwrite QEMU_OPTIONS and neglect
> to manually set '-machine accel=qtest'. Add the missing option for 172.
> 186 probably only copied the code from 172, it doesn't actually need to
> overwrite QEMU_OPTIONS, so remove that in 186.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  tests/qemu-iotests/172 | 2 +-
>  tests/qemu-iotests/186 | 6 +++---
>  2 files changed, 4 insertions(+), 4 deletions(-)

I tested this on top of my change switching the default machine to
"tcg:kvm:xen:hax", and this now passes on x86_64 builds both with and
without tcg.

Tested-by: Cornelia Huck <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>