[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] block: Clean up some bad code in the vvfat driv
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH] block: Clean up some bad code in the vvfat driver |
Date: |
Tue, 19 Sep 2017 10:02:21 +0200 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
Am 13.09.2017 um 12:21 hat Thomas Huth geschrieben:
> Remove the unnecessary home-grown redefinition of the assert() macro here,
> and remove the unusable debug code at the end of the checkpoint() function.
> The code there uses assert() with side-effects (assignment to the "mapping"
> variable), which should be avoided. Looking more closely, it seems as it is
> apparently also only usable for one certain directory layout (with a file
> named USB.H in it) and thus is of no use for the rest of the world.
>
> Signed-off-by: Thomas Huth <address@hidden>
Thanks, applied to the block branch.
Kevin
Re: [Qemu-block] [PATCH] block: Clean up some bad code in the vvfat driver,
Kevin Wolf <=