[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v3 4/6] block: Add blkdebug hook for copy-on-read
From: |
Eric Blake |
Subject: |
[Qemu-block] [PATCH v3 4/6] block: Add blkdebug hook for copy-on-read |
Date: |
Thu, 5 Oct 2017 14:02:46 -0500 |
Make it possible to inject errors on writes performed during a
read operation due to copy-on-read semantics.
Signed-off-by: Eric Blake <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
Reviewed-by: John Snow <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
---
qapi/block-core.json | 5 ++++-
block/io.c | 1 +
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 750bb0c77c..ab96e348e6 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -2538,6 +2538,8 @@
#
# @l1_shrink_free_l2_clusters: discard the l2 tables. (since 2.11)
#
+# @cor_write: a write due to copy-on-read (since 2.11)
+#
# Since: 2.9
##
{ 'enum': 'BlkdebugEvent', 'prefix': 'BLKDBG',
@@ -2555,7 +2557,8 @@
'flush_to_disk', 'pwritev_rmw_head', 'pwritev_rmw_after_head',
'pwritev_rmw_tail', 'pwritev_rmw_after_tail', 'pwritev',
'pwritev_zero', 'pwritev_done', 'empty_image_prepare',
- 'l1_shrink_write_table', 'l1_shrink_free_l2_clusters' ] }
+ 'l1_shrink_write_table', 'l1_shrink_free_l2_clusters',
+ 'cor_write'] }
##
# @BlkdebugInjectErrorOptions:
diff --git a/block/io.c b/block/io.c
index 94f74703b7..a5598ed869 100644
--- a/block/io.c
+++ b/block/io.c
@@ -983,6 +983,7 @@ static int coroutine_fn bdrv_co_do_copy_on_readv(BdrvChild
*child,
goto err;
}
+ bdrv_debug_event(bs, BLKDBG_COR_WRITE);
if (drv->bdrv_co_pwrite_zeroes &&
buffer_is_zero(bounce_buffer, iov.iov_len)) {
/* FIXME: Should we (perhaps conditionally) be setting
--
2.13.6
- [Qemu-block] [PATCH v3 0/6] block: Avoid copy-on-read assertions, Eric Blake, 2017/10/05
- [Qemu-block] [PATCH v3 1/6] qemu-io: Add -C for opening with copy-on-read, Eric Blake, 2017/10/05
- [Qemu-block] [PATCH v3 2/6] block: Uniform handling of 0-length bdrv_get_block_status(), Eric Blake, 2017/10/05
- [Qemu-block] [PATCH v3 3/6] iotests: Restore stty settings on completion, Eric Blake, 2017/10/05
- [Qemu-block] [PATCH v3 4/6] block: Add blkdebug hook for copy-on-read,
Eric Blake <=
- [Qemu-block] [PATCH v3 5/6] block: Perform copy-on-read in loop, Eric Blake, 2017/10/05
- [Qemu-block] [PATCH v3 6/6] iotests: Add test 197 for covering copy-on-read, Eric Blake, 2017/10/05
- Re: [Qemu-block] [PATCH v3 0/6] block: Avoid copy-on-read assertions, Kevin Wolf, 2017/10/06