[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 1/2] nbd/server: fix nbd_negotiate_handle_info
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH 1/2] nbd/server: fix nbd_negotiate_handle_info |
Date: |
Thu, 2 Nov 2017 12:54:10 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 11/01/2017 10:42 AM, Vladimir Sementsov-Ogievskiy wrote:
It's best to send a 0/2 cover letter for a series, even when both
patches are small, as that helps automation tools.
> namelen should be here, lenght is unrelated.
s/lenght/length/
Broken in introduction in commit f37708f6; hence adding qemu-stable in cc.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> nbd/server.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/nbd/server.c b/nbd/server.c
> index 70b40ed27e..7fcec0af7e 100644
> --- a/nbd/server.c
> +++ b/nbd/server.c
> @@ -433,7 +433,7 @@ static int nbd_negotiate_handle_info(NBDClient *client,
> uint32_t length,
>
> /* Don't bother sending NBD_INFO_NAME unless client requested it */
> if (sendname) {
> - rc = nbd_negotiate_send_info(client, opt, NBD_INFO_NAME, length,
> name,
> + rc = nbd_negotiate_send_info(client, opt, NBD_INFO_NAME, namelen,
> name,
Interestingly enough, length == 0 at this point, so we would always
report that the export name is '' (aka the default export), without
actually being a protocol violation. Doesn't hurt qemu as a client,
since we don't ask for NBD_INFO_NAME, but may break other NBD client
implementations, if they then use NBD_OPT_GO on the '' name expecting it
to resolve to the same non-empty name they just queried on NBD_OPT_INFO.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature