[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v3 6/7] block/curl: fix minor memor
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v3 6/7] block/curl: fix minor memory leaks |
Date: |
Wed, 8 Nov 2017 02:08:08 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
Hi Jeff,
On 11/07/2017 07:27 PM, Jeff Cody wrote:
"Missed in 1bff9606429."
> Signed-off-by: Jeff Cody <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> block/curl.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/block/curl.c b/block/curl.c
> index 00a9879..35cf417 100644
> --- a/block/curl.c
> +++ b/block/curl.c
> @@ -857,6 +857,9 @@ out_noclean:
> qemu_mutex_destroy(&s->mutex);
> g_free(s->cookie);
> g_free(s->url);
> + g_free(s->username);
> + g_free(s->proxyusername);
> + g_free(s->proxypassword);
> qemu_opts_del(opts);
> return -EINVAL;
> }
> @@ -955,6 +958,9 @@ static void curl_close(BlockDriverState *bs)
>
> g_free(s->cookie);
> g_free(s->url);
> + g_free(s->username);
> + g_free(s->proxyusername);
> + g_free(s->proxypassword);
> }
>
> static int64_t curl_getlength(BlockDriverState *bs)
>
- [Qemu-block] [PATCH v3 0/7] Code cleanup and minor fixes (for 2.11), Jeff Cody, 2017/11/07
- [Qemu-block] [PATCH v3 3/7] block/sheepdog: remove spurious NULL check, Jeff Cody, 2017/11/07
- [Qemu-block] [PATCH v3 2/7] block/ssh: make compliant with coding guidelines, Jeff Cody, 2017/11/07
- [Qemu-block] [PATCH v3 6/7] block/curl: fix minor memory leaks, Jeff Cody, 2017/11/07
- [Qemu-block] [PATCH v3 1/7] block/ssh: don't call libssh2_init() in block_init(), Jeff Cody, 2017/11/07
- [Qemu-block] [PATCH v3 5/7] block/curl: check error return of curl_global_init(), Jeff Cody, 2017/11/07
- [Qemu-block] [PATCH v3 7/7] block/curl: code cleanup to comply with coding style, Jeff Cody, 2017/11/07