[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 00/17] iotests: Fix iotests for weird formats/op
From: |
Fam Zheng |
Subject: |
Re: [Qemu-block] [PATCH 00/17] iotests: Fix iotests for weird formats/options |
Date: |
Thu, 23 Nov 2017 15:24:38 +0800 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Thu, 11/23 03:08, Max Reitz wrote:
> (I hate to write Python tests because the boilerplate seems so large and
> the debugging is so hard. But there is test 194 which shows that it is
> possible to write simple bash-like tests as well--and that is how I
> should probably write tests from now on.)
If the boilerplate means copy&paste from another test it is not a big problem;
if you really mean it's more cumbersome than bash to write test code, I think we
can try new ways to exploit Python's expressiveness. 2c93c5cb43 and f4844ac0ad
are good examples.
So what do you think about debugging? IMO the biggest problem is the less
verbose reference output, and lack of a separate logging channel. We can and
should improve that, even for existing scripts.
And yes, the 194 style is actually better than "iotests.QMPTestCase" ones.
Fam
- [Qemu-block] [PATCH 10/17] iotests: Fix 020 for vmdk, (continued)
- [Qemu-block] [PATCH 10/17] iotests: Fix 020 for vmdk, Max Reitz, 2017/11/22
- [Qemu-block] [PATCH 13/17] iotests: Fix 067 for compat=0.10, Max Reitz, 2017/11/22
- [Qemu-block] [PATCH 14/17] iotests: Make 089 compatible with compat=0.10, Max Reitz, 2017/11/22
- [Qemu-block] [PATCH 15/17] iotests: Make 184 image-less, Max Reitz, 2017/11/22
- [Qemu-block] [PATCH 16/17] iotests: Make 191 work with qcow2 options, Max Reitz, 2017/11/22
- [Qemu-block] [PATCH 17/17] iotests: Filter compat-dependent info in 198, Max Reitz, 2017/11/22
- Re: [Qemu-block] [PATCH 00/17] iotests: Fix iotests for weird formats/options, Max Reitz, 2017/11/22
- Re: [Qemu-block] [Qemu-devel] [PATCH 00/17] iotests: Fix iotests for weird formats/options, no-reply, 2017/11/22
- Re: [Qemu-block] [PATCH 00/17] iotests: Fix iotests for weird formats/options,
Fam Zheng <=
- [Qemu-block] [PATCH 18/17] iotests: Make 059 pass on machines with little RAM, Max Reitz, 2017/11/29