|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-block] [PATCH] block: Fix qemu crash when using scsi-block |
Date: | Thu, 23 Nov 2017 11:42:15 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 23/11/2017 11:23, Stefan Hajnoczi wrote: > You are right. I audited the blk_aio_preadv() callers and they all keep > qiov around until the request is complete. > > Actually this makes sense because even in the simple non-coroutine case > with aio=threads the qiov hasn't necessarily been read yet when the > function returns. The aio_worker() function executes later and only > then is qiov handed to the host kernel. > > So this is a one-off bug in blk_aio_ioctl() callers. Only in blk_aio_ioctl, not in the callers. Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |