[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v7 10/20] qcow: Switch to .bdrv_co_block_status()
From: |
Eric Blake |
Subject: |
[Qemu-block] [PATCH v7 10/20] qcow: Switch to .bdrv_co_block_status() |
Date: |
Fri, 5 Jan 2018 16:57:43 -0600 |
We are gradually moving away from sector-based interfaces, towards
byte-based. Update the qcow driver accordingly. There is no
intent to optimize based on the want_zero flag for this format.
Signed-off-by: Eric Blake <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
---
v5-v7: no change
v4: rebase to interface tweak
v3: rebase to master
v2: rebase to mapping flag
---
block/qcow.c | 27 ++++++++++++++++-----------
1 file changed, 16 insertions(+), 11 deletions(-)
diff --git a/block/qcow.c b/block/qcow.c
index 9569deeaf0..f09661dc0c 100644
--- a/block/qcow.c
+++ b/block/qcow.c
@@ -513,23 +513,28 @@ static int get_cluster_offset(BlockDriverState *bs,
return 1;
}
-static int64_t coroutine_fn qcow_co_get_block_status(BlockDriverState *bs,
- int64_t sector_num, int nb_sectors, int *pnum, BlockDriverState **file)
+static int coroutine_fn qcow_co_block_status(BlockDriverState *bs,
+ bool want_zero,
+ int64_t offset, int64_t bytes,
+ int64_t *pnum, int64_t *map,
+ BlockDriverState **file)
{
BDRVQcowState *s = bs->opaque;
- int index_in_cluster, n, ret;
+ int index_in_cluster, ret;
+ int64_t n;
uint64_t cluster_offset;
qemu_co_mutex_lock(&s->lock);
- ret = get_cluster_offset(bs, sector_num << 9, 0, 0, 0, 0, &cluster_offset);
+ ret = get_cluster_offset(bs, offset, 0, 0, 0, 0, &cluster_offset);
qemu_co_mutex_unlock(&s->lock);
if (ret < 0) {
return ret;
}
- index_in_cluster = sector_num & (s->cluster_sectors - 1);
- n = s->cluster_sectors - index_in_cluster;
- if (n > nb_sectors)
- n = nb_sectors;
+ index_in_cluster = offset & (s->cluster_size - 1);
+ n = s->cluster_size - index_in_cluster;
+ if (n > bytes) {
+ n = bytes;
+ }
*pnum = n;
if (!cluster_offset) {
return 0;
@@ -537,9 +542,9 @@ static int64_t coroutine_fn
qcow_co_get_block_status(BlockDriverState *bs,
if ((cluster_offset & QCOW_OFLAG_COMPRESSED) || s->crypto) {
return BDRV_BLOCK_DATA;
}
- cluster_offset |= (index_in_cluster << BDRV_SECTOR_BITS);
+ *map = cluster_offset | index_in_cluster;
*file = bs->file->bs;
- return BDRV_BLOCK_DATA | BDRV_BLOCK_OFFSET_VALID | cluster_offset;
+ return BDRV_BLOCK_DATA | BDRV_BLOCK_OFFSET_VALID;
}
static int decompress_buffer(uint8_t *out_buf, int out_buf_size,
@@ -1111,7 +1116,7 @@ static BlockDriver bdrv_qcow = {
.bdrv_co_readv = qcow_co_readv,
.bdrv_co_writev = qcow_co_writev,
- .bdrv_co_get_block_status = qcow_co_get_block_status,
+ .bdrv_co_block_status = qcow_co_block_status,
.bdrv_make_empty = qcow_make_empty,
.bdrv_co_pwritev_compressed = qcow_co_pwritev_compressed,
--
2.14.3
- [Qemu-block] [PATCH v7 02/20] block: Switch passthrough drivers to .bdrv_co_block_status(), (continued)
- [Qemu-block] [PATCH v7 02/20] block: Switch passthrough drivers to .bdrv_co_block_status(), Eric Blake, 2018/01/05
- [Qemu-block] [PATCH v7 04/20] gluster: Switch to .bdrv_co_block_status(), Eric Blake, 2018/01/05
- [Qemu-block] [PATCH v7 05/20] iscsi: Switch cluster_sectors to byte-based, Eric Blake, 2018/01/05
- [Qemu-block] [PATCH v7 06/20] iscsi: Switch iscsi_allocmap_update() to byte-based, Eric Blake, 2018/01/05
- [Qemu-block] [PATCH v7 07/20] iscsi: Switch to .bdrv_co_block_status(), Eric Blake, 2018/01/05
- [Qemu-block] [PATCH v7 08/20] null: Switch to .bdrv_co_block_status(), Eric Blake, 2018/01/05
- [Qemu-block] [PATCH v7 09/20] parallels: Switch to .bdrv_co_block_status(), Eric Blake, 2018/01/05
- [Qemu-block] [PATCH v7 10/20] qcow: Switch to .bdrv_co_block_status(),
Eric Blake <=
- [Qemu-block] [PATCH v7 11/20] qcow2: Switch to .bdrv_co_block_status(), Eric Blake, 2018/01/05
- [Qemu-block] [PATCH v7 13/20] raw: Switch to .bdrv_co_block_status(), Eric Blake, 2018/01/05
- [Qemu-block] [PATCH v7 12/20] qed: Switch to .bdrv_co_block_status(), Eric Blake, 2018/01/05
- [Qemu-block] [PATCH v7 14/20] sheepdog: Switch to .bdrv_co_block_status(), Eric Blake, 2018/01/05
- [Qemu-block] [PATCH v7 15/20] vdi: Avoid bitrot of debugging code, Eric Blake, 2018/01/05
- [Qemu-block] [PATCH v7 16/20] vdi: Switch to .bdrv_co_block_status(), Eric Blake, 2018/01/05
- [Qemu-block] [PATCH v7 17/20] vmdk: Switch to .bdrv_co_block_status(), Eric Blake, 2018/01/05
- [Qemu-block] [PATCH v7 18/20] vpc: Switch to .bdrv_co_block_status(), Eric Blake, 2018/01/05
- [Qemu-block] [PATCH v7 19/20] vvfat: Switch to .bdrv_co_block_status(), Eric Blake, 2018/01/05