[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 09/19] block: Nested drain_end must still cal
Re: [Qemu-block] [PATCH v2 09/19] block: Nested drain_end must still call callbacks
Mon, 8 Jan 2018 19:00:15 +0100
Am 08.01.2018 um 16:41 hat Alberto Garcia geschrieben:
> On Thu 21 Dec 2017 03:22:41 PM CET, Kevin Wolf wrote:
> > bdrv_do_drained_begin() restricts the call of parent callbacks and
> > aio_disable_external() to the outermost drain section, but the block
> > driver callbacks are always called. bdrv_do_drained_end() must match
> > this behaviour, otherwise nodes stay drained even if begin/end calls
> > were balanced.
> Is this patch in the correct place in the series? I was confused becaue
> you mention bdrv_do_drained_begin() and bdrv_do_drained_end() that don't
> seem to exist yet, I see you add them in a later patch.
I think I only forgot to update the commit message when I had to move
some patches around so I could attack one bug after another and keep the
The series has landed in master today, so for this kind of thing it's
too late anyway, but additional review never hurts. If you find
something, we'll have to do a follow-up patch.