[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 0/7] Call check and invalidate_cache from cor
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH v2 0/7] Call check and invalidate_cache from coroutine context |
Date: |
Wed, 17 Jan 2018 14:33:36 +0100 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
Am 17.01.2018 um 14:15 hat Paolo Bonzini geschrieben:
> On 17/01/2018 13:59, Kevin Wolf wrote:
> > Am 17.01.2018 um 12:25 hat Paolo Bonzini geschrieben:
> >> Check and invalidate_cache share some parts of the implementation
> >> with the regular I/O path. This is sometimes complicated because the
> >> I/O path wants to use a CoMutex but that is not possible outside coroutine
> >> context. By moving things to coroutine context, we can remove special
> >> cases. In fact, invalidate_cache is already called from coroutine context
> >> because incoming migration is placed in a coroutine.
> >>
> >> While at it, I'm including two patches from Stefan to rename the
> >> bdrv_create callback to bdrv_co_create, because it is already called
> >> from coroutine context.
> > I'm using .bdrv_co_create for the QAPI type based function that will be
> > used from QMP blockdev-create, so it would be good if we leave the
> > legacy function with its old name or at least choose a different new
> > name for it.
>
> .bdrv_co_create_opts since it takes QemuOpts*?
Sounds good enough to me.
Kevin
- [Qemu-block] [PATCH v2 0/7] Call check and invalidate_cache from coroutine context, Paolo Bonzini, 2018/01/17
- [Qemu-block] [PATCH 2/7] qcow2: make qcow2_co_create2() a coroutine_fn, Paolo Bonzini, 2018/01/17
- [Qemu-block] [PATCH 3/7] qcow2: make qcow2_do_open a coroutine_fn, Paolo Bonzini, 2018/01/17
- [Qemu-block] [PATCH 4/7] qed: make bdrv_qed_do_open a coroutine_fn, Paolo Bonzini, 2018/01/17
- [Qemu-block] [PATCH 6/7] qcow2: introduce qcow2_write_caches and qcow2_flush_caches, Paolo Bonzini, 2018/01/17
- [Qemu-block] [PATCH 1/7] block: rename .bdrv_create() to .bdrv_co_create(), Paolo Bonzini, 2018/01/17
- [Qemu-block] [PATCH 5/7] block: convert bdrv_invalidate_cache callback to coroutine_fn, Paolo Bonzini, 2018/01/17
- [Qemu-block] [PATCH 7/7] block: convert bdrv_check callback to coroutine_fn, Paolo Bonzini, 2018/01/17
- Re: [Qemu-block] [PATCH v2 0/7] Call check and invalidate_cache from coroutine context, Kevin Wolf, 2018/01/17