[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH v2 16/32] qcow2: Update l2_allocate

From: Anton Nefedov
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH v2 16/32] qcow2: Update l2_allocate() to support L2 slices
Date: Wed, 17 Jan 2018 19:57:32 +0300
User-agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2

On 17/1/2018 6:42 PM, Alberto Garcia wrote:
On Tue 16 Jan 2018 05:52:36 PM CET, Anton Nefedov wrote:

Cosmetic: maybe this l2_load() better be merged with the copied L2 case?

    if (!(l1_table[l1_index] & COPIED))

I'm not sure about that, since there's also the qcow2_free_clusters()
call afterwards, so the final code might be harder to follow.


actually shouldn't qcow2_free_clusters() be done before l2_load()?
Otherwise we bail out on error and leak space.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]