[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH v2 24/32] qcow2: Update qcow2_updat

From: Alberto Garcia
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH v2 24/32] qcow2: Update qcow2_update_snapshot_refcount() to support L2 slices
Date: Thu, 18 Jan 2018 16:43:39 +0100
User-agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu)

On Wed 17 Jan 2018 12:00:59 AM CET, Eric Blake wrote:
>> -    l2_table = NULL;
>> +    l2_slice = NULL;
>>      l1_table = NULL;
>>      l1_size2 = l1_size * sizeof(uint64_t);
>> +    slice_size = s->l2_slice_size * sizeof(uint64_t);
> Again, better naming on s->l2_slice_size in an earlier patch may make
> this more readable, at a cost of slight rebase churn.

Another approach would be to use _size2 to refer to size in bytes, after
checking the code a bit that seems to be the convention in other places
where we're dealing with both table lenghts and sizes in bytes.

> The diff looks hideous, but that's thanks to indentation changes.

Right, that's why I suggested to use 'diff -w' in the cover letter to
help see the changes better.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]