[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH] raw: Disable probing if image form
Re: [Qemu-block] [Qemu-devel] [PATCH] raw: Disable probing if image format is given by driver-specific options
Tue, 23 Jan 2018 11:05:07 +0800
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2
On 01/23/2018 12:45 AM, Max Reitz wrote:
On 2018-01-22 08:21, Lin Ma wrote:
If the user specifies image format through driver-specific options, The
format probing should be prohibited and the warning message should not
$ qemu-system-x86_64 ... -drive file.file.filename=disk0.raw,file.driver=raw ...
WARNING: Image format was not specified for 'disk0.raw' and probing guessed raw.
Automatically detecting the format is dangerous for raw images, ...
Signed-off-by: Lin Ma <address@hidden>
blockdev.c | 2 ++
1 file changed, 2 insertions(+)
But what has been proped is the driver for the root BDS, so the warning
is actually correct.
(That command line is creating a chain of three BDS:
raw (probed) -> raw (explicitly specified) -> file (default protocol))