[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v2 2/8] qapi: add unmap to BlockDeviceStats

From: Anton Nefedov
Subject: Re: [Qemu-block] [PATCH v2 2/8] qapi: add unmap to BlockDeviceStats
Date: Tue, 23 Jan 2018 13:35:04 +0300
User-agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2

On 22/1/2018 11:47 PM, Eric Blake wrote:
On 01/19/2018 06:50 AM, Anton Nefedov wrote:
Signed-off-by: Anton Nefedov <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
  qapi/block-core.json       | 29 +++++++++++++++++++++++------
  include/block/accounting.h |  1 +
  block/qapi.c               |  6 ++++++
  3 files changed, 30 insertions(+), 6 deletions(-)

@@ -688,6 +693,9 @@
  # @rd_total_time_ns: Total_time_spend on reads in nano-seconds (since 0.15.0).

While we are here, we could change s/Total_time_spend/Total time spent/

+# @unmap_total_time_ns: Total time spent on unmap operations in nano-seconds
+#                       (Since 2.12)

Also, s/nano-seconds/nanoseconds/ (for both lines, if we are touching both).

The QAPI maintainer can touch that up (that may be me, depending on
Markus' schedule in the next few weeks); but I'm not seeing any UI
problems with the addition, so

Reviewed-by: Eric Blake <address@hidden>

Thanks, fixed

reply via email to

[Prev in Thread] Current Thread [Next in Thread]