[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] iotests: Fix CID for VMDK afl image
From: |
Fam Zheng |
Subject: |
Re: [Qemu-block] [PATCH] iotests: Fix CID for VMDK afl image |
Date: |
Thu, 1 Feb 2018 08:55:22 +0800 |
On Thu, Feb 1, 2018 at 2:58 AM, Max Reitz <address@hidden> wrote:
> On 2018-01-30 07:25, Fam Zheng wrote:
>> This reverts commit 76bf133c4 which updated the reference output, and
>> fixed the reference image, because the code path we want to exercise is
>> actually the invalid image size.
>>
>> The descriptor block in the image, which includes the CID to verify, has been
>> invalid since the reference image was added. Since commit 9877860e7bd we
>> report
>> this error earlier than the "file too large", so 059.out mismatches.
>>
>> The binary change is generated along the operations of:
>>
>> $ bunzip2 afl9.vmdk.bz2
>> $ qemu-img create -f vmdk fix.vmdk 1G
>> $ dd if=afl9.vmdk.bz2 of=fix.vmdk bs=512 count=1 conv=notrunc
>> $ mv fix.vmdk afl9.vmdk
>> $ bzip2 afl9.vmdk
>>
>> Signed-off-by: Fam Zheng <address@hidden>
>>
>> ---
>>
>> v2: Fix commit message "qcow2 -> vmdk". [Kevin]
>> Revert 76bf133c4.
>
> Hmmmm, now this fails again on my 32 bit build. :-(
>
> The issue there is that you get a "Cannot allocate memory" when trying
> to open the file. My current fix was 2291712c39111a732 which simply
> converted that to "Invalid argument", but now it's getting a bit more
> complicated... Should I just continue to play the game and check the
> output for "Cannot allocate memory" and print exactly what the reference
> output is expecting...?
Ahhh. OK, then, with a big comment.
I'd say let's just _notrun on 32 bit.
Fam