[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 1/1] nbd: implement bdrv_get_info callback

From: Edgar Kaziakhmedov
Subject: Re: [Qemu-block] [PATCH 1/1] nbd: implement bdrv_get_info callback
Date: Fri, 2 Feb 2018 17:23:37 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2

On 02/02/2018 05:15 PM, Eric Blake wrote:
On 02/02/2018 08:06 AM, Edgar Kaziakhmedov wrote:

However, it would be nice to remove can_write_zeroes_with_unmap from
BlockDriverInfo, and make bdrv_can_write_zeroes_with_unmap just return
!!(bs->supported_zero_flags & BDRV_REQ_MAY_UNMAP).  Kevin, what do you
Actually, I may even just give a shot at writing this alternative patch,
to make Kevin's decision easier.
But actually qcow2 performs some checks for version inside get_info
callback before setting can_write_zeroes_with_unmap flag,
so we can't take into account such checks in
bdrv_can_write_zeroes_with_unmap subroutine. Therefore, I don't think it
is possible to do it like that.
Here's the patch I proposed (it looks like I forgot to CC you):


Yes, it was possible to move check to open, ok, get it.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]