[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 21/39] qcow2: Update qcow2_alloc_cluster_link
Re: [Qemu-block] [PATCH v3 21/39] qcow2: Update qcow2_alloc_cluster_link_l2() to support L2 slices
Fri, 02 Feb 2018 10:43:12 +0100
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu)
On Thu 01 Feb 2018 07:44:56 PM CET, Max Reitz <address@hidden> wrote:
> On 2018-01-26 15:59, Alberto Garcia wrote:
>> There's a loop in this function that iterates over the L2 entries in a
>> table, so now we need to assert that it remains within the limits of
>> an L2 slice.
>> Apart from that, this function doesn't need any additional changes, so
>> this patch simply updates the variable name from l2_table to l2_slice.
>> Signed-off-by: Alberto Garcia <address@hidden>
>> Reviewed-by: Eric Blake <address@hidden>
>> block/qcow2-cluster.c | 16 ++++++++--------
>> 1 file changed, 8 insertions(+), 8 deletions(-)
> Hm, well, strictly speaking this patch should not be at this point in
> this series -- e.g. handle_alloc() so far only limits its nb_clusters to
> the L2 size, not the L2 slice size.
Yeah, I didn't try to be too strict with this because you can only
change the slice size after everything else is ready.