Re: [Qemu-block] [PATCH v2] block: maintain persistent disabled bitmaps

[Vladimir Sementsov-Ogievskiy]

02.02.2018 18:23, Max Reitz wrote:
> On 2018-02-02 16:18, Vladimir Sementsov-Ogievskiy wrote:
> > 31.01.2018 22:04, Max Reitz wrote:
> > > On 2018-01-29 19:43, Max Reitz wrote:
> > > > On 2018-01-22 11:41, Vladimir Sementsov-Ogievskiy wrote:
> > > > > To maintain load/store disabled bitmap there is new approach:
> > > > >
> > > > >    - deprecate @autoload flag of block-dirty-bitmap-add, make it ignored
> > > > >    - store enabled bitmaps as "auto" to qcow2
> > > > >    - store disabled bitmaps without "auto" flag to qcow2
> > > > >    - on qcow2 open load "auto" bitmaps as enabled and others
> > > > >      as disabled (except in_use bitmaps)
> > > > >
> > > > > Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> > > > > Reviewed-by: John Snow <address@hidden>
> > > > > ---
> > > > Thanks, looks very reasonable.  Applied to my block branch:
> > > >
> > > > https://github.com/XanClic/qemu/commits/block
> > > ...aaand I've only just now seen that iotest 176 will need to be fixed
> > > along with this, so I'm going to unqueue this patch for now.
> > ohh, sorry for that. Will resend today.
> >
> > > And when I'm already at it: Should we add deprecation information to
> > > qemu-doc.texi?
> > didn't find anything in qemu-doc.texi about dirty bitmaps, so I think, no.
> I mean in the "Deprecated features" appendix.  I think whenever we
> deprecate something, it should be noted there (as far as I've understood).

Ok, understand, will add. (hmm no section for QMP in this appendix, I'll 
be the first =(

> (Also on the Wiki, I think.)

nothing about autoload and persistent parameters in the wiki ( 
https://wiki.qemu.org/Features/IncrementalBackup , nothing else ? ). 
Hovewer, it is good idea to update material in wiki, I'll think about it.

> > Is there a way to generate some documentation files from qapi comments?
> > Where is it?
> There is docs/interop/qemu-qmp-qapi.texi in the build directory.
>
> Max


--
Best regards,
Vladimir