[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH] block: early check for blockers on drive-mirror
From: |
Paolo Bonzini |
Subject: |
[Qemu-block] [PATCH] block: early check for blockers on drive-mirror |
Date: |
Wed, 7 Feb 2018 17:29:20 +0100 |
Even if an op blocker is present for BLOCK_OP_TYPE_MIRROR_SOURCE,
it is checked a bit late and the result is that the target is
created even if drive-mirror subsequently fails. Add an early
check to avoid this.
Signed-off-by: Paolo Bonzini <address@hidden>
---
blockdev.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/blockdev.c b/blockdev.c
index 8e977eef11..c7e2e0a00e 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -3565,6 +3565,11 @@ void qmp_drive_mirror(DriveMirror *arg, Error **errp)
return;
}
+ /* Early check to avoid creating target */
+ if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_MIRROR_SOURCE, errp)) {
+ return;
+ }
+
aio_context = bdrv_get_aio_context(bs);
aio_context_acquire(aio_context);
--
2.14.3
- [Qemu-block] [PATCH] block: early check for blockers on drive-mirror,
Paolo Bonzini <=
- Re: [Qemu-block] [Qemu-devel] [PATCH] block: early check for blockers on drive-mirror, Fam Zheng, 2018/02/07
- Re: [Qemu-block] [PATCH] block: early check for blockers on drive-mirror, Alberto Garcia, 2018/02/08
- Re: [Qemu-block] [PATCH] block: early check for blockers on drive-mirror, Alberto Garcia, 2018/02/08
- Re: [Qemu-block] [PATCH] block: early check for blockers on drive-mirror, Kevin Wolf, 2018/02/09
- Re: [Qemu-block] [Qemu-devel] [PATCH] block: early check for blockers on drive-mirror, John Snow, 2018/02/09