[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 01/27] block/qapi: Introduce BlockdevCreateOptio

From: Eric Blake
Subject: Re: [Qemu-block] [PATCH 01/27] block/qapi: Introduce BlockdevCreateOptions
Date: Thu, 8 Feb 2018 16:48:02 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2

On 02/08/2018 01:23 PM, Kevin Wolf wrote:
This creates a BlockdevCreateOptions union type that will contain all of
the options for image creation. We'll start out with an empty struct
type BlockdevCreateDummy for all drivers.

Name here...

Signed-off-by: Kevin Wolf <address@hidden>
  qapi/block-core.json | 61 ++++++++++++++++++++++++++++++++++++++++++++++++++++
  1 file changed, 61 insertions(+)

diff --git a/qapi/block-core.json b/qapi/block-core.json
index 8225308904..b59b1430bb 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -3338,6 +3338,67 @@
  { 'command': 'blockdev-del', 'data': { 'node-name': 'str' } }
+# @BlockdevCreateNotSupported:

...should match what you use here.

With that obvious fix,
Reviewed-by: Eric Blake <address@hidden>

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]